- Address warnings about 64-bit to 32-bit conversions.

runtime/bin/filter.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_FILTER_H_
 #define BIN_FILTER_H_
 
 #include "bin/builtin.h"
 #include "bin/utils.h"
 
@@ skipping 36 matching lines @@
  private:
   static const intptr_t kFilterBufferSize = 64 * KB;
   uint8_t processed_buffer_[kFilterBufferSize];
   bool initialized_;
 
   DISALLOW_COPY_AND_ASSIGN(Filter);
 };
 
 class ZLibDeflateFilter : public Filter {
  public:
-  ZLibDeflateFilter(bool gzip = false, int level = 6)
+  ZLibDeflateFilter(bool gzip = false, int32_t level = 6)

[Søren Gjesse, 2014/01/15 10:38:43]

Just use int64_t to avoid the static cast in filter.cc.

[Ivan Posva, 2014/01/16 05:05:41]

That would be pushing the issue just downstream. The static cast would still
have to happen in filter.cc just at a different place. The way it is setup now
it allows us to report an error when creating the ZLibDeflateFilter, which is
where we would be passing the bad parameter instead of later when the deflation
is invoked.

     : gzip_(gzip), level_(level), current_buffer_(NULL) {}
   virtual ~ZLibDeflateFilter();
 
   virtual bool Init();
   virtual bool Process(uint8_t* data, intptr_t length);
   virtual intptr_t Processed(uint8_t* buffer,
                              intptr_t length,
                              bool finish,
                              bool end);
 
  private:
   const bool gzip_;
-  const int level_;
+  const int32_t level_;
   uint8_t* current_buffer_;
   z_stream stream_;
 
   DISALLOW_COPY_AND_ASSIGN(ZLibDeflateFilter);
 };
 
 class ZLibInflateFilter : public Filter {
  public:
   ZLibInflateFilter() : current_buffer_(NULL) {}
   virtual ~ZLibInflateFilter();
 
   virtual bool Init();
   virtual bool Process(uint8_t* data, intptr_t length);
   virtual intptr_t Processed(uint8_t* buffer,
                              intptr_t length,
                              bool finish,
                              bool end);
 
  private:
   uint8_t* current_buffer_;
   z_stream stream_;
 
   DISALLOW_COPY_AND_ASSIGN(ZLibInflateFilter);
 };
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // BIN_FILTER_H_