Chromium Code Reviews| Index: runtime/bin/filter.cc |
| =================================================================== |
| --- runtime/bin/filter.cc (revision 31816) |
| +++ runtime/bin/filter.cc (working copy) |
| @@ -60,12 +60,13 @@ |
| Dart_ThrowException(DartUtils::NewInternalError( |
| "Failed to get 'gzip' parameter")); |
| } |
| - int64_t level; |
| - if (Dart_IsError(Dart_IntegerToInt64(level_obj, &level))) { |
| + int64_t level = 0; |
| + if (Dart_IsError(Dart_IntegerToInt64(level_obj, &level)) || |
| + (level < kMinInt32) || (level > kMaxInt32)) { |
|
siva
2014/01/16 00:15:59
Would be more readable if this code is written as:
Ivan Posva
2014/01/16 05:05:41
Done.
|
| Dart_ThrowException(DartUtils::NewInternalError( |
| "Failed to get 'level' parameter")); |
| } |
| - Filter* filter = new ZLibDeflateFilter(gzip, level); |
| + Filter* filter = new ZLibDeflateFilter(gzip, static_cast<int32_t>(level)); |
| if (filter == NULL || !filter->Init()) { |
| delete filter; |
| Dart_ThrowException(DartUtils::NewInternalError( |