- Address warnings about 64-bit to 32-bit conversions.

runtime/bin/filter.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/filter.h"
 #include "bin/io_buffer.h"
 
 #include "include/dart_api.h"
 
@@ skipping 42 matching lines @@
 
 void FUNCTION_NAME(Filter_CreateZLibDeflate)(Dart_NativeArguments args) {
   Dart_Handle filter_obj = Dart_GetNativeArgument(args, 0);
   Dart_Handle gzip_obj = Dart_GetNativeArgument(args, 1);
   Dart_Handle level_obj = Dart_GetNativeArgument(args, 2);
   bool gzip;
   if (Dart_IsError(Dart_BooleanValue(gzip_obj, &gzip))) {
     Dart_ThrowException(DartUtils::NewInternalError(
         "Failed to get 'gzip' parameter"));
   }
-  int64_t level;
-  if (Dart_IsError(Dart_IntegerToInt64(level_obj, &level))) {
+  int64_t level = 0;
+  if (Dart_IsError(Dart_IntegerToInt64(level_obj, &level)) ||
+      (level < kMinInt32) || (level > kMaxInt32)) {

[siva, 2014/01/16 00:15:59]

Would be more readable if this code is written as:
Dart_Handle result = Dart_IntegerToInt64(level_obj, &level);
if (Dart_IsError(result) || (level < kMinInt32) || (level > kMaxInt32)) {
...
}

Feels weird when the condition has side effects (setting level in this case)

[Ivan Posva, 2014/01/16 05:05:41]

Done.

     Dart_ThrowException(DartUtils::NewInternalError(
         "Failed to get 'level' parameter"));
   }
-  Filter* filter = new ZLibDeflateFilter(gzip, level);
+  Filter* filter = new ZLibDeflateFilter(gzip, static_cast<int32_t>(level));
   if (filter == NULL || !filter->Init()) {
     delete filter;
     Dart_ThrowException(DartUtils::NewInternalError(
         "Failed to create ZLibDeflateFilter"));
   }
   Dart_Handle result = Filter::SetFilterPointerNativeField(filter_obj, filter);
   if (Dart_IsError(result)) {
     delete filter;
     Dart_PropagateError(result);
   }
@@ skipping 225 matching lines @@
     case Z_STREAM_ERROR:
       // An error occoured.
       delete[] current_buffer_;
       current_buffer_ = NULL;
       return -1;
   }
 }
 
 }  // namespace bin
 }  // namespace dart