Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6838)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/delete_tree_work_item.cc

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc ('k') | chrome/service/cloud_print/print_system_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/delete_tree_work_item.cc
diff --git a/chrome/installer/util/delete_tree_work_item.cc b/chrome/installer/util/delete_tree_work_item.cc
index 9cc47ede0058478f9fa718f5d36be482358cfab5..dcb8d1ebc001556c9ddc1afce01dab125c6d544f 100644
--- a/chrome/installer/util/delete_tree_work_item.cc
+++ b/chrome/installer/util/delete_tree_work_item.cc
@@ -67,7 +67,10 @@ bool DeleteTreeWorkItem::Do() {
PLOG(ERROR) << "Could not back up " << key_file.value()
<< " to directory " << backup.path().value();
abort = true;
- backup.Delete();
+ if (!backup.Delete()) {
+ PLOG(ERROR) << "Could not clean up temp dir in "
+ << temp_path_.value();
+ }
}
}
if (!abort) {
« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc ('k') | chrome/service/cloud_print/print_system_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698