Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4209)

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/delete_tree_work_item.cc ('k') | chrome/utility/importer/ie_importer_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/cloud_print/print_system_win.cc
diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc
index 26c5626373bd17e3f580838d4f89a649124602da..02016cf76978e202ffd9565b08541e156a3e9fd1 100644
--- a/chrome/service/cloud_print/print_system_win.cc
+++ b/chrome/service/cloud_print/print_system_win.cc
@@ -7,6 +7,7 @@
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/json/json_writer.h"
+#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/utf_string_conversions.h"
#include "base/thread_task_runner_handle.h"
@@ -435,7 +436,7 @@ class JobSpoolerWin : public PrintSystem::JobSpooler {
pdf_path,
printing::PdfRenderSettings(render_area, render_dpi, false))) {
// The object will self-destruct when the child process dies.
- utility_host.release();
+ ignore_result(utility_host.release());
} else {
client_task_runner->PostTask(
FROM_HERE, base::Bind(&Core::PrintJobDone, this, false));
@@ -575,7 +576,7 @@ class PrinterCapsHandler : public ServiceUtilityProcessHost::Client {
new ServiceUtilityProcessHost(this, client_task_runner.get()));
if (utility_host->StartGetPrinterCapsAndDefaults(printer_name_)) {
// The object will self-destruct when the child process dies.
- utility_host.release();
+ ignore_result(utility_host.release());
} else {
client_task_runner->PostTask(
FROM_HERE, base::Bind(&PrinterCapsHandler::OnChildDied, this));
@@ -589,7 +590,7 @@ class PrinterCapsHandler : public ServiceUtilityProcessHost::Client {
new ServiceUtilityProcessHost(this, client_task_runner.get()));
if (utility_host->StartGetPrinterSemanticCapsAndDefaults(printer_name_)) {
// The object will self-destruct when the child process dies.
- utility_host.release();
+ ignore_result(utility_host.release());
} else {
client_task_runner->PostTask(
FROM_HERE, base::Bind(&PrinterCapsHandler::OnChildDied, this));
« no previous file with comments | « chrome/installer/util/delete_tree_work_item.cc ('k') | chrome/utility/importer/ie_importer_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698