chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc - Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

index 8270b45ad52f0e912020b86237731bf95607659c..9ef043b27e65b691aed554ddaa19cc51c961bfc8 100644

--- a/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc

@@ -56,7 +56,7 @@ class BinaryIntegrityAnalyzerWinTest : public ::testing::Test {

};

BinaryIntegrityAnalyzerWinTest::BinaryIntegrityAnalyzerWinTest() {

- temp_dir_.CreateUniqueTempDir();

+ EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());

base::CreateDirectory(temp_dir_.path().AppendASCII(CHROME_VERSION_STRING));

// We retrieve DIR_TEST_DATA here because it is based on DIR_EXE and we are

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | chrome/installer/util/delete_tree_work_item.cc » ('j') | no next file with comments »