Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1390143002: Revert of Re-land: ui: Add GLImage unit test framework. (Closed)

Created:
5 years, 2 months ago by Kunihiko Sakamoto
Modified:
5 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: ui: Add GLImage unit test framework. (patchset #18 id:340001 of https://codereview.chromium.org/1354483004/ ) Reason for revert: libosmesa open failure has gone, but tests are still failing. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32956 http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32957 http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32958 Original issue's description: > Re-land: ui: Add GLImage unit test framework. > > This makes it possible to test GLImage implementations without > requiring multi-process GpuMemoryBuffer support. > > This initial version is limited to testing CopyTexSubImage with > the default buffer format but testing of more functionality and > formats will be added in follow up patches. > > Also inlcudes some minor cleanup needed to not have GLImage > implementations depend on GpuMemoryBuffer API. > > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/11b3655a4dfd5b46f7783421e2959a41ddbf3a00 > Cr-Commit-Position: refs/heads/master@{#352767} TBR=dcastagna@chromium.org,glider@chromium.org,piman@chromium.org,sky@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/de89c773fbb6bf9c8484fcb3f11256594417b5aa Cr-Commit-Position: refs/heads/master@{#352779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -683 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/test/test_image_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M components/mus/mus_app.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/vm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_shared_memory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vt_video_decode_accelerator.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/BUILD.gn View 4 chunks +0 lines, -18 lines 0 comments Download
M ui/gl/gl.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gl/gl_api_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/gl/gl_context.cc View 1 chunk +4 lines, -1 line 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gl/gl_image_io_surface.mm View 3 chunks +4 lines, -4 lines 0 comments Download
D ui/gl/gl_image_ref_counted_memory_unittest.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M ui/gl/gl_image_shared_memory.h View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/gl/gl_image_shared_memory.cc View 2 chunks +5 lines, -7 lines 0 comments Download
D ui/gl/gl_image_shared_memory_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +3 lines, -1 line 0 comments Download
M ui/gl/gl_tests.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
D ui/gl/test/gl_image_test_support.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gl/test/gl_image_test_support.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D ui/gl/test/gl_image_test_template.h View 1 chunk +0 lines, -182 lines 0 comments Download
M ui/gl/test/gl_surface_test_support.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/gl/test/gl_surface_test_support.cc View 1 chunk +5 lines, -10 lines 0 comments Download
D ui/gl/test/gl_test_helper.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ui/gl/test/gl_test_helper.cc View 1 chunk +0 lines, -141 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kunihiko Sakamoto
Created Revert of Re-land: ui: Add GLImage unit test framework.
5 years, 2 months ago (2015-10-07 05:48:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390143002/1
5 years, 2 months ago (2015-10-07 05:49:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 05:52:09 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 05:52:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de89c773fbb6bf9c8484fcb3f11256594417b5aa
Cr-Commit-Position: refs/heads/master@{#352779}

Powered by Google App Engine
This is Rietveld 408576698