gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 139013008: Implement support for rendering to 32-bit float textures on ES3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 139013008: Implement support for rendering to 32-bit float textures on ES3 (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix extension names that are a substring of another name in FeatureInfo Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/framebuffer_manager.cc ('K') | « gpu/command_buffer/service/framebuffer_manager_unittest.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index f913c4883d5ebdb892dd908c2d97842b026ba4fc..9e31f6f07b7f1114356ecafcfede471739de9a52 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -2959,7 +2959,7 @@ bool GLES2DecoderImpl::CheckFramebufferValid(

return true;

}

- GLenum completeness = framebuffer->IsPossiblyComplete();

+ GLenum completeness = framebuffer->IsPossiblyComplete(feature_info_.get());

if (completeness != GL_FRAMEBUFFER_COMPLETE) {

LOCAL_SET_GL_ERROR(

GL_INVALID_FRAMEBUFFER_OPERATION, func_name, "framebuffer incomplete");

@@ -4895,7 +4895,7 @@ GLenum GLES2DecoderImpl::DoCheckFramebufferStatus(GLenum target) {

if (!framebuffer) {

return GL_FRAMEBUFFER_COMPLETE;

}

- GLenum completeness = framebuffer->IsPossiblyComplete();

+ GLenum completeness = framebuffer->IsPossiblyComplete(feature_info_.get());

if (completeness != GL_FRAMEBUFFER_COMPLETE) {

return completeness;

}