Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1389213004: Fix dm with Chromium command buffer driver (Closed)

Created:
5 years, 2 months ago by Kimmo Kinnunen
Modified:
5 years, 2 months ago
Reviewers:
hendrikw, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix dm with Chromium command buffer driver Fix a crash in dm when run with Chromium command buffer driver. Also removes glCopyTextureCHROMIUM, it does not seem to be used. This is removed on the grounds that it would need similar change, if it was used. The variable fCopyTextureCHROMIUM does not seem to be populated in the Chromium side, either. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/0adfffba1bee55eee9e31e809cd0089840722b26

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Kimmo Kinnunen
5 years, 2 months ago (2015-10-12 07:04:37 UTC) #2
hendrikw
On 2015/10/12 07:04:37, Kimmo Kinnunen wrote: This crash happening last week, looks like it was ...
5 years, 2 months ago (2015-10-12 18:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389213004/20001
5 years, 2 months ago (2015-10-13 03:28:19 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-13 03:28:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3167)
5 years, 2 months ago (2015-10-13 03:29:32 UTC) #8
bsalomon
On 2015/10/13 03:29:32, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-13 18:01:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389213004/20001
5 years, 2 months ago (2015-10-13 19:57:59 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 19:58:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0adfffba1bee55eee9e31e809cd0089840722b26

Powered by Google App Engine
This is Rietveld 408576698