Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1376293003: Fix for 2056 (Closed)

Created:
5 years, 2 months ago by joshua.litt
Modified:
5 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback incorporated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M src/gpu/gl/GrGLCaps.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
this is pretty trivial, ptal
5 years, 2 months ago (2015-09-30 19:51:32 UTC) #2
bsalomon
https://codereview.chromium.org/1376293003/diff/1/src/gpu/gl/GrGLCaps.h File src/gpu/gl/GrGLCaps.h (right): https://codereview.chromium.org/1376293003/diff/1/src/gpu/gl/GrGLCaps.h#newcode266 src/gpu/gl/GrGLCaps.h:266: bool bindUniformLocation() const { return fBindUniformLocation; } I think ...
5 years, 2 months ago (2015-09-30 20:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376293003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376293003/20001
5 years, 2 months ago (2015-10-01 13:21:42 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 13:28:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7bdd70ab9162980f3173c98c48234f9f345665a3

Powered by Google App Engine
This is Rietveld 408576698