dart2js cps_ir: Use interceptors for is-checks.

Use interceptors for is-checks.

Use the $isXXX properties for type tests on raw (non-parameterized) types.

Use special builtin operations for the weird JSArray type hierarchy.

Still TODO:

If the only use of an interceptor is a single 'getInterceptor(value).$isXXX', and XXX is not a supertype of a native type, replace with 'value instanceof XXX'.

New version at: https://codereview.chromium.org/1385423002

[sra1, 2015-10-06 05:15:17]

Patchset #1 (id:1) has been deleted

[sra1, 2015-10-06 05:20:17]

sra@google.com changed reviewers:
+ asgerf@google.com

[sra1, 2015-10-06 06:40:07]

Patchset #1 (id:20001) has been deleted

[sra1, 2015-10-06 06:47:58]

This is work in progress.

There are a few benchmarks that catch up to SSA.

I think I want to move things around and only introduce TypeTestRaw during
type_propagation, but I'm a bit stuck on introducing two primitives at once.

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/builtin_operator.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/builtin_operator.dart:111: /// Precondition:
Argument is a JavaScript Array.
I'm pretty sure there are some places where this is not true.
However, this is no worse than what it is replacing.

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:2756: if (type.isInterfaceType
&& type.isRaw) {
I think this could me moved to type_propagation.

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart:357: return "TypeTestRaw ($value
${node.dartType}$interceptor)";
How is this tested?

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1870: void unlinkInterceptor()
{
If instead of removing the interceptor, we add one if needed, then we are
generating

   letPrim p1 = Interceptor x in
     letPrim p2 = TypeTestRaw p1 in
       ...

I'm not sure how to so that given this visitor method is called from
visitLetPrim for p2.  It seems that I can't get reanalyze to start from the
right place.

Perhaps each primitive needs to finish the job by tail-calling into code
equivalent to the continuation of visit() in visitLetPrim.

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1897: 
I think what I would like to do is replace the current TypeTestRaw primitive
with a test based on the property on an opaque input (the object or its
interceptor).

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:2324: break;
What to I do for primitives that return JS values that only make sense in a
truthy/falsy context?

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/tr...
File pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/tr...
pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart:507: return
'$object."is-${node.dartType}"';
How do I test this?

[sra1, 2015-10-07 03:40:04]

Ping.

I also have a cleaned-up version where the new Primitive is only for the
via-interceptor-flag tests:
https://codereview.chromium.org/1385423002

[sra1, 2015-10-07 03:40:50]

sra@google.com changed reviewers:
+ kmillikin@chromium.org

[sra1, 2015-10-07 03:41:16]

sra@google.com changed reviewers:
+ kmillikin@google.com
- kmillikin@chromium.org

[sra1, 2015-10-07 03:55:34]

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/type_propagation.dart:1897: 
On 2015/10/06 06:47:58, sra1 wrote:
> I think what I would like to do is replace the current TypeTestRaw primitive
> with a test based on the property on an opaque input (the object or its
> interceptor).

I did this in the new CL https://codereview.chromium.org/1385423002

[sra1, 2015-10-07 04:01:06]

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right):

https://codereview.chromium.org/1388473003/diff/40001/pkg/compiler/lib/src/cp...
pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:2756: if (type.isInterfaceType
&& type.isRaw) {
On 2015/10/06 06:47:58, sra1 wrote:
> I think this could me moved to type_propagation.

Done.