Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1388473003: dart2js cps_ir: Use interceptors for is-checks. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index 01b5847cdb3073f8153280f6368fee513bed1c72..b310650a199ef9228614544c8bbeda1e72a4319d 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -498,6 +498,15 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
return '$element = $value';
}
+ String visitGetTypeTestProperty(GetTypeTestProperty node) {
+ String object = visitExpression(node.object);
+ if (usesInfixNotation(node.object)) {
+ object = '($object)';
+ }
+ // TODO(sra): Fix up this.
+ return '$object."is-${node.dartType}"';
sra1 2015/10/06 06:47:58 How do I test this?
+ }
+
String visitCreateBox(CreateBox node) {
return 'CreateBox';
}
@@ -611,4 +620,4 @@ class Names {
}
return name;
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698