Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1388473003: dart2js cps_ir: Use interceptors for is-checks. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index 8adf3a9171e3a46432e915c49a531b6d1b8fd60c..b91475c0174d25691c229614f9079eff39e62aa8 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -641,6 +641,17 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
return new TypeOperator(value, node.dartType, typeArgs, isTypeTest: true);
}
+ Expression visitTypeTestRaw(cps_ir.TypeTestRaw node) {
+ if (node.usePropertyTest) {
+ Expression value = getVariableUse(node.value);
+ // TODO(sra): Move !! to cps_ir level.
+ return new Not(new Not(new GetTypeTestProperty(value, node.dartType)));
+ }
+ Expression value = getVariableUse(node.value);
+ List<Expression> typeArgs = <Expression>[];
+ return new TypeOperator(value, node.dartType, typeArgs, isTypeTest: true);
+ }
+
Expression visitGetStatic(cps_ir.GetStatic node) {
return new GetStatic(node.element, node.sourceInformation);
}
@@ -700,4 +711,3 @@ class Builder implements cps_ir.Visitor/*<NodeCallback|Node>*/ {
visitContinuation(cps_ir.Continuation node) => unexpectedNode(node);
visitMutableVariable(cps_ir.MutableVariable node) => unexpectedNode(node);
}
-

Powered by Google App Engine
This is Rietveld 408576698