Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388413005: Move //mojo/services/X/public/... to //mojo/services/X/... (part 1). (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move //mojo/services/X/public/... to //mojo/services/X/... (part 1). X = asset_bundle, authenticating_url_loader_interceptor, authentication, camera, clipboard, contacts, content_handler, device_info, files R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08e339a30cfbe8034b933e0ca8368b8dfb5c1b98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -6199 lines) Patch
M apps/moterm/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/moterm/README.md View 1 chunk +1 line, -1 line 0 comments Download
M apps/moterm/moterm_driver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/moterm/moterm_driver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/moterm/moterm_driver_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/moterm/moterm_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/content_handler_demo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/forwarding_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/repl.js View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/moterm_example_app/moterm_example_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/native_run_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/native_run_app/native_run_app.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M examples/pdf_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/content_handler_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/asset_bundle/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/asset_bundle/interfaces/asset_bundle.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/asset_bundle/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/asset_bundle/public/interfaces/asset_bundle.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
A + mojo/services/authenticating_url_loader_interceptor/interfaces/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/authenticating_url_loader_interceptor/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/authenticating_url_loader_interceptor/public/interfaces/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/authenticating_url_loader_interceptor/public/interfaces/authenticating_url_loader_interceptor_meta_factory.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
A + mojo/services/authentication/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/authentication/interfaces/authentication.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/authentication/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/authentication/public/interfaces/authentication.mojom View 1 chunk +0 lines, -29 lines 0 comments Download
A + mojo/services/camera/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/camera/interfaces/camera.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/camera/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/camera/public/interfaces/camera.mojom View 1 chunk +0 lines, -37 lines 0 comments Download
A + mojo/services/clipboard/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/clipboard/interfaces/clipboard.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/clipboard/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/clipboard/public/interfaces/clipboard.mojom View 1 chunk +0 lines, -44 lines 0 comments Download
A + mojo/services/contacts/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/contacts/interfaces/contacts.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/contacts/public/interfaces/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/services/contacts/public/interfaces/contacts.mojom View 1 chunk +0 lines, -36 lines 0 comments Download
A + mojo/services/content_handler/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/content_handler/interfaces/content_handler.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/content_handler/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/content_handler/public/interfaces/content_handler.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
A + mojo/services/device_info/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/device_info/interfaces/device_info.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/device_info/public/interfaces/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D mojo/services/device_info/public/interfaces/device_info.mojom View 1 chunk +0 lines, -27 lines 0 comments Download
A + mojo/services/files/c/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/directory_wrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/lib/directory_wrapper.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/files/c/lib/errno_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/c/lib/fd_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/lib/fd_table.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/fd_table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/lib/file_fd_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/c/lib/file_fd_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + mojo/services/files/c/lib/mojio_fcntl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/c/lib/mojio_sys_stat.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/lib/mojio_unistd.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/c/lib/real_errno_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/real_errno_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/singletons.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/singletons.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/c/lib/template_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/c/lib/util.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/lib/util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/mojio_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/files/c/mojio_fcntl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/mojio_stdio.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/mojio_sys_stat.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/c/mojio_sys_types.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/c/mojio_time.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/mojio_unistd.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/tests/directory_wrapper_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + mojo/services/files/c/tests/errno_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/tests/fd_table_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/c/tests/file_fd_impl_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/files/c/tests/mock_errno_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/tests/mock_errno_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/tests/mojio_impl_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/tests/mojio_impl_test_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/c/tests/mojio_sys_stat_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/tests/mojio_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/tests/mojio_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/tests/mojio_unistd_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/tests/real_errno_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/c/tests/test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/c/tests/test_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/tests/test_utils_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/c/tests/util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/cpp/input_stream_file.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/cpp/lib/input_stream_file.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/cpp/lib/output_stream_file.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/cpp/output_stream_file.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/cpp/tests/input_stream_file_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/cpp/tests/output_stream_file_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/interfaces/directory.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/interfaces/file.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/interfaces/files.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/interfaces/ioctl.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/interfaces/ioctl_terminal.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/interfaces/types.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/services/files/public/c/BUILD.gn View 1 chunk +0 lines, -92 lines 0 comments Download
D mojo/services/files/public/c/lib/directory_wrapper.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/services/files/public/c/lib/directory_wrapper.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D mojo/services/files/public/c/lib/errno_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/services/files/public/c/lib/fd_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/services/files/public/c/lib/fd_table.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mojo/services/files/public/c/lib/fd_table.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/services/files/public/c/lib/file_fd_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/services/files/public/c/lib/file_fd_impl.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D mojo/services/files/public/c/lib/mojio_fcntl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/files/public/c/lib/mojio_sys_stat.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/files/public/c/lib/mojio_unistd.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D mojo/services/files/public/c/lib/real_errno_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/files/public/c/lib/real_errno_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/files/public/c/lib/singletons.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/services/files/public/c/lib/singletons.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D mojo/services/files/public/c/lib/template_util.h View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/services/files/public/c/lib/util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/files/public/c/lib/util.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D mojo/services/files/public/c/mojio_config.h View 1 chunk +0 lines, -38 lines 0 comments Download
D mojo/services/files/public/c/mojio_fcntl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/services/files/public/c/mojio_stdio.h View 1 chunk +0 lines, -203 lines 0 comments Download
D mojo/services/files/public/c/mojio_sys_stat.h View 1 chunk +0 lines, -128 lines 0 comments Download
D mojo/services/files/public/c/mojio_sys_types.h View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/files/public/c/mojio_time.h View 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/services/files/public/c/mojio_unistd.h View 1 chunk +0 lines, -155 lines 0 comments Download
D mojo/services/files/public/c/tests/directory_wrapper_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D mojo/services/files/public/c/tests/errno_impl_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/services/files/public/c/tests/fd_table_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D mojo/services/files/public/c/tests/file_fd_impl_unittest.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D mojo/services/files/public/c/tests/mock_errno_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/services/files/public/c/tests/mock_errno_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_impl_test_base.h View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_impl_test_base.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_sys_stat_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_test_base.h View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_test_base.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/services/files/public/c/tests/mojio_unistd_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D mojo/services/files/public/c/tests/real_errno_impl_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/services/files/public/c/tests/test_utils.h View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/services/files/public/c/tests/test_utils.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D mojo/services/files/public/c/tests/test_utils_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/services/files/public/c/tests/util_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/services/files/public/cpp/BUILD.gn View 1 chunk +0 lines, -59 lines 0 comments Download
D mojo/services/files/public/cpp/input_stream_file.h View 1 chunk +0 lines, -159 lines 0 comments Download
D mojo/services/files/public/cpp/lib/input_stream_file.cc View 1 chunk +0 lines, -302 lines 0 comments Download
D mojo/services/files/public/cpp/lib/output_stream_file.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D mojo/services/files/public/cpp/output_stream_file.h View 1 chunk +0 lines, -114 lines 0 comments Download
D mojo/services/files/public/cpp/tests/input_stream_file_unittest.cc View 1 chunk +0 lines, -539 lines 0 comments Download
D mojo/services/files/public/cpp/tests/output_stream_file_unittest.cc View 1 chunk +0 lines, -287 lines 0 comments Download
D mojo/services/files/public/interfaces/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/services/files/public/interfaces/directory.mojom View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/services/files/public/interfaces/file.mojom View 1 chunk +0 lines, -92 lines 0 comments Download
D mojo/services/files/public/interfaces/files.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
D mojo/services/files/public/interfaces/ioctl.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/services/files/public/interfaces/ioctl_terminal.mojom View 1 chunk +0 lines, -184 lines 0 comments Download
D mojo/services/files/public/interfaces/types.mojom View 1 chunk +0 lines, -102 lines 0 comments Download
M mojo/services/mojo_services.gni View 1 chunk +9 lines, -9 lines 0 comments Download
M mojo/services/native_support/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_support/public/interfaces/process.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/terminal/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/terminal/public/interfaces/terminal.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/terminal/public/interfaces/terminal_client.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/android/java_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M services/asset_bundle/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M services/asset_bundle/asset_bundle_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/asset_bundle/asset_bundle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/asset_bundle/asset_unpacker_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/asset_bundle/asset_unpacker_job.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_app.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_meta_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/authentication/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/authentication/dummy_authentication_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/camera/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/clipboard/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/clipboard/clipboard_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/clipboard/clipboard_standalone_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/contacts/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/contacts/contacts_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/device_info/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/device_info/device_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/files/directory_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/files_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/files_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/files_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/files/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/files/shared_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/files/util.h View 1 chunk +1 line, -1 line 0 comments Download
M services/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M services/native_support/process_controller_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_support/process_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/process_controller_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/native_support/process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/process_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/native_support/process_io_redirection.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_support/redirectors.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/python/content_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/vanadium/security/principal_service.go View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M shell/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M shell/application_manager/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M shell/application_manager/application_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M shell/application_manager/shell_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1398973004 Patch 1

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-10-09 18:08:56 UTC) #1
jamesr
This'll break the sky roll, which Jason is trying to go through right now. Can ...
5 years, 2 months ago (2015-10-09 18:10:02 UTC) #2
jamesr
rs lgtm
5 years, 2 months ago (2015-10-09 23:26:03 UTC) #3
viettrungluu
5 years, 2 months ago (2015-10-10 08:03:15 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
08e339a30cfbe8034b933e0ca8368b8dfb5c1b98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698