Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: chrome/browser/extensions/bundle_installer.h

Issue 138803012: Fix use-after-free in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bundle_installer.h
diff --git a/chrome/browser/extensions/bundle_installer.h b/chrome/browser/extensions/bundle_installer.h
index 2edda54982fe91518d5b2de2dffe531ee76cd4bf..f5edfeef142b8d92491a1584f29f99a76bc60614 100644
--- a/chrome/browser/extensions/bundle_installer.h
+++ b/chrome/browser/extensions/bundle_installer.h
@@ -23,7 +23,7 @@ class DictionaryValue;
} // namespace base
namespace content {
-class NavigationController;
+class WebContents;
} // namespace content
class Browser;
@@ -96,11 +96,10 @@ class BundleInstaller : public WebstoreInstallHelper::Delegate,
// If the bundle has been approved, this downloads and installs the member
// extensions. OnBundleInstallComplete will be called when the process is
// complete and |delegate| is not NULL. The download process uses the
- // specified |controller|. When complete, we show a confirmation bubble in
- // the specified |browser|.
+ // NavigationController of the specified |web_contents|. When complete, we
+ // show a confirmation bubble in the specified |browser|.
// Note: the |delegate| must stay alive until receiving the callback.
- void CompleteInstall(content::NavigationController* controller,
- Delegate* delegate);
+ void CompleteInstall(content::WebContents* web_contents, Delegate* delegate);
// We change the headings in the install prompt and installed bubble depending
// on whether the bundle contains apps, extensions or both. This method gets
« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_api.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698