Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/extensions/bundle_installer.cc

Issue 138803012: Fix use-after-free in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/bundle_installer.h ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/bundle_installer.cc
diff --git a/chrome/browser/extensions/bundle_installer.cc b/chrome/browser/extensions/bundle_installer.cc
index 88cf2394447f091b871934238fa11e4ad632051a..5b8e07c484d72a43852279a2434068a618393849 100644
--- a/chrome/browser/extensions/bundle_installer.cc
+++ b/chrome/browser/extensions/bundle_installer.cc
@@ -19,7 +19,6 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
-#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
#include "extensions/common/extension.h"
#include "extensions/common/permissions/permission_set.h"
@@ -27,8 +26,6 @@
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
-using content::NavigationController;
-
namespace extensions {
namespace {
@@ -136,7 +133,7 @@ void BundleInstaller::PromptForApproval(Delegate* delegate) {
ParseManifests();
}
-void BundleInstaller::CompleteInstall(NavigationController* controller,
+void BundleInstaller::CompleteInstall(content::WebContents* web_contents,
Delegate* delegate) {
CHECK(approved_);
@@ -168,7 +165,7 @@ void BundleInstaller::CompleteInstall(NavigationController* controller,
scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(
profile_,
this,
- controller,
+ web_contents,
i->first,
approval.Pass(),
WebstoreInstaller::INSTALL_SOURCE_OTHER);
« no previous file with comments | « chrome/browser/extensions/bundle_installer.h ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698