chrome/browser/extensions/api/webstore_private/webstore_private_api.cc - Issue 138803012: Fix use-after-free in WebstoreInstaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

Issue 138803012: Fix use-after-free in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

index 95dfcd6c769b49ec1541dc3c8a5bcb12402a7e33..652cd80c947e7bf46279e84158f614580bf31595 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

@@ -240,7 +240,7 @@ bool WebstorePrivateInstallBundleFunction::

void WebstorePrivateInstallBundleFunction::OnBundleInstallApproved() {

bundle_->CompleteInstall(

- &(dispatcher()->delegate()->GetAssociatedWebContents()->GetController()),

+ dispatcher()->delegate()->GetAssociatedWebContents(),

this);

}

@@ -570,7 +570,7 @@ bool WebstorePrivateCompleteInstallFunction::RunImpl() {

scoped_refptr<WebstoreInstaller> installer = new WebstoreInstaller(

GetProfile(),

this,

- &(dispatcher()->delegate()->GetAssociatedWebContents()->GetController()),

+ dispatcher()->delegate()->GetAssociatedWebContents(),

params->expected_id,

approval_.Pass(),

WebstoreInstaller::INSTALL_SOURCE_OTHER);

« no previous file with comments | « no previous file | chrome/browser/extensions/bundle_installer.h » ('j') | no next file with comments »