input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK 1.004.

input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK 1.004.

If an input element has the following style,
 - line-height: Npx
 - FontMetrics::height(): M (where M > N)

|line-height| for innerEditor was removed, and the innerEditor
and the input content box were aligned at the top edge.  So, the
bottom part of the text was clipped if |height| is specified and
it's smaller than FontMetrics::height().

This behavior is required because all browsers ignore
|line-height| if |height| is not specified.

Typically an error of author style causes this
situation. However, with Noto Sans 1.004, FontMetrics::height()
is larger than font-size, and the bottom part of text was clipped
even if <input style="font-size:16px; line-height:16px;
height:16px;">.  Authors don't expect this behavior.

This CL updates the code so that we don't remove |line-height|
from innerEditor if |height| is specified.  This centers
innerEditor vertically.

BUG=519331
Committed: https://crrev.com/bfa2f33f86fd947ce27dafbde21b3557b6d990fc
Cr-Commit-Position: refs/heads/master@{#352313}

[tkent, 2015-10-05 05:46:55]

Patchset #1 (id:1) has been deleted

[tkent, 2015-10-05 05:47:04]

Patchset #1 (id:20001) has been deleted

[tkent, 2015-10-05 05:47:34]

tkent@chromium.org changed reviewers:
+ kojii@chromium.org

[tkent, 2015-10-05 05:47:35]

Koji-san, can you review this?

[kojii, 2015-10-05 08:30:25]

lgtm

[tkent, 2015-10-05 10:15:16]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2015-10-05 10:15:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387783003/40001

[commit-bot: I haz the power, 2015-10-05 10:20:18]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2015-10-05 10:21:48]

Patchset 1 (id:??) landed as
https://crrev.com/bfa2f33f86fd947ce27dafbde21b3557b6d990fc
Cr-Commit-Position: refs/heads/master@{#352313}

[caitp (gmail), 2015-10-06 15:32:32]

On 2015/10/05 10:21:48, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/bfa2f33f86fd947ce27dafbde21b3557b6d990fc
> Cr-Commit-Position: refs/heads/master@{#352313}

[caitp (gmail), 2015-10-06 15:33:33]

On 2015/10/06 15:32:32, caitp wrote:
> On 2015/10/05 10:21:48, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/bfa2f33f86fd947ce27dafbde21b3557b6d990fc
> > Cr-Commit-Position: refs/heads/master@{#352313}

https://crbug.com/539858 --> there might be a few pieces missing from this CL
that would solve these issues. Sorry for the extra email, it was sent by
mistake.

[tkent, 2015-10-06 23:56:43]

A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.chromium.org/1386343002/ by tkent@chromium.org.

The reason for reverting is: Caused a regression on github, crbug.com/539858.