Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1386343002: Revert of input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK 1.004. (Closed)

Created:
5 years, 2 months ago by tkent
Modified:
5 years, 2 months ago
Reviewers:
kojii
CC:
asanka, benjhayden+dwatch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK 1.004. (patchset #1 id:40001 of https://codereview.chromium.org/1387783003/ ) Reason for revert: Caused a regression on github, crbug.com/539858 Original issue's description: > input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK 1.004. > > If an input element has the following style, > - line-height: Npx > - FontMetrics::height(): M (where M > N) > > |line-height| for innerEditor was removed, and the innerEditor > and the input content box were aligned at the top edge. So, the > bottom part of the text was clipped if |height| is specified and > it's smaller than FontMetrics::height(). > > This behavior is required because all browsers ignore > |line-height| if |height| is not specified. > > Typically an error of author style causes this > situation. However, with Noto Sans 1.004, FontMetrics::height() > is larger than font-size, and the bottom part of text was clipped > even if <input style="font-size:16px; line-height:16px; > height:16px;">. Authors don't expect this behavior. > > This CL updates the code so that we don't remove |line-height| > from innerEditor if |height| is specified. This centers > innerEditor vertically. > > BUG=519331 > > Committed: https://crrev.com/bfa2f33f86fd947ce27dafbde21b3557b6d990fc > Cr-Commit-Position: refs/heads/master@{#352313} TBR=kojii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=519331, 539858 Committed: https://crrev.com/dff049387c258666fb0d06da7d1048f2a4d2f05d Cr-Commit-Position: refs/heads/master@{#352718}

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of input[type=text]: Add a workaround to fix vertical position of Noto Sans CJK ...
5 years, 2 months ago (2015-10-06 23:56:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386343002/1
5 years, 2 months ago (2015-10-07 00:00:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 00:05:51 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 00:07:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dff049387c258666fb0d06da7d1048f2a4d2f05d
Cr-Commit-Position: refs/heads/master@{#352718}

Powered by Google App Engine
This is Rietveld 408576698