[Android] With gyp_managed_install no device is only a warning

build/android/gyp/util/build_utils.py

Index: build/android/gyp/util/build_utils.py
diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py
index b8b94622d910ef41ea998567d3c10416b8fcf264..897b6fc94917ff899a46976efb08fb4799dab203 100644
--- a/build/android/gyp/util/build_utils.py
+++ b/build/android/gyp/util/build_utils.py
@@ -81,7 +81,8 @@ def ReadJson(path):
 # This can be used in most cases like subprocess.check_call. The output,
 # particularly when the command fails, better highlights the command's failure.
 # This call will directly exit on a failure in the subprocess so that no python
-# stacktrace is printed after the output of the failed command.
+# stacktrace is printed after the output of the failed command (and will
+# instead print a python stack trace before the output of the failed command)
 def CheckCallDie(args, suppress_output=False, cwd=None):
   if not cwd:
     cwd = os.getcwd()
@@ -128,3 +129,18 @@ def IsTimeStale(output, inputs):
     if GetModifiedTime(input) > output_time:
       return True
   return False
+
+
+def IsDeviceReady():
+  device_state = CheckCallDie(['adb', 'get-state'], suppress_output=True)

[newt (away), 2013/04/29 21:23:57]

what happens if multiple devices are attached?

[cjhopman, 2013/04/30 00:32:15]

adb get-state returns "unknown" with multiple devices attached so this will
return false.

This is sort of what we want, since all the steps will fail when there are
multiple devices attached. So in that case the build will now succeed, but the
warning message might be a bit(/a lot) confusing.

+  return device_state.strip() == 'device'
+
+
+def PrintWarning(message):
+  print 'WARNING: ' + message
+
+
+def PrintBigWarning(message):
+  print '*****     ' * 8
+  PrintWarning(message)
+  print '*****     ' * 8