[Android] With gyp_managed_install no device is only a warning

build/android/gyp/util/build_utils.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import fnmatch
 import json
 import os
 import pipes
 import shlex
 import shutil
@@ skipping 63 matching lines @@
       outfile.write(new_dump)
 
 def ReadJson(path):
   with open(path, 'r') as jsonfile:
     return json.load(jsonfile)
 
 
 # This can be used in most cases like subprocess.check_call. The output,
 # particularly when the command fails, better highlights the command's failure.
 # This call will directly exit on a failure in the subprocess so that no python
-# stacktrace is printed after the output of the failed command.
+# stacktrace is printed after the output of the failed command (and will
+# instead print a python stack trace before the output of the failed command)
 def CheckCallDie(args, suppress_output=False, cwd=None):
   if not cwd:
     cwd = os.getcwd()
 
   child = subprocess.Popen(args,
       stdout=subprocess.PIPE, stderr=subprocess.STDOUT, cwd=cwd)
 
   stdout, _ = child.communicate()
 
   if child.returncode:
@@ skipping 26 matching lines @@
 
 def IsTimeStale(output, inputs):
   if not os.path.exists(output):
     return True
 
   output_time = GetModifiedTime(output)
   for input in inputs:
     if GetModifiedTime(input) > output_time:
       return True
   return False
+
+
+def IsDeviceReady():
+  device_state = CheckCallDie(['adb', 'get-state'], suppress_output=True)

[newt (away), 2013/04/29 21:23:57]

what happens if multiple devices are attached?

[cjhopman, 2013/04/30 00:32:15]

adb get-state returns "unknown" with multiple devices attached so this will
return false.

This is sort of what we want, since all the steps will fail when there are
multiple devices attached. So in that case the build will now succeed, but the
warning message might be a bit(/a lot) confusing.

+  return device_state.strip() == 'device'
+
+
+def PrintWarning(message):
+  print 'WARNING: ' + message
+
+
+def PrintBigWarning(message):
+  print '*****     ' * 8
+  PrintWarning(message)
+  print '*****     ' * 8