build/android/gyp/push_libraries.py - Issue 13877025: [Android] With gyp_managed_install no device is only a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/push_libraries.py

Issue 13877025: [Android] With gyp_managed_install no device is only a warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/push_libraries.py

diff --git a/build/android/gyp/push_libraries.py b/build/android/gyp/push_libraries.py

index 4f110a469fb441dd1b0c779ea69e6ed9337475a1..085d766453ac914d903165d99b18efbb18366c44 100755

--- a/build/android/gyp/push_libraries.py

+++ b/build/android/gyp/push_libraries.py

@@ -48,6 +48,11 @@ def DoPush(options):

def main(argv):

+ if not build_utils.IsDeviceReady():

+ build_utils.PrintBigWarning(

+ 'No device attached. Skipping native library push.')

newt (away) 2013/04/30 00:34:42 how about "Zero (or multiple) devices attached. S

+ return

parser = optparse.OptionParser()

parser.add_option('--libraries-dir',

help='Directory that contains stripped libraries.')