Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2610)

Unified Diff: build/android/gyp/create_device_library_links.py

Issue 13877025: [Android] With gyp_managed_install no device is only a warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/gyp/create_device_library_links.py
diff --git a/build/android/gyp/create_device_library_links.py b/build/android/gyp/create_device_library_links.py
index 5b8ee2b021613941199d38dd6e808deb8d08a33a..5bfde5f63301d024acff6acc4c04f2a81177d8e4 100755
--- a/build/android/gyp/create_device_library_links.py
+++ b/build/android/gyp/create_device_library_links.py
@@ -76,6 +76,11 @@ def TriggerSymlinkScript(options):
def main(argv):
+ if not build_utils.IsDeviceReady():
+ build_utils.PrintBigWarning(
+ 'No device attached. Skipping creating symlinks.')
+ return
+
parser = optparse.OptionParser()
parser.add_option('--apk', help='Path to the apk.')
parser.add_option('--script-host-path',

Powered by Google App Engine
This is Rietveld 408576698