build/android/gyp/apk_install.py - Issue 13877025: [Android] With gyp_managed_install no device is only a warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/gyp/apk_install.py

Issue 13877025: [Android] With gyp_managed_install no device is only a warning (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/gyp/apk_install.py

diff --git a/build/android/gyp/apk_install.py b/build/android/gyp/apk_install.py

index 714be081ca14c1084284e57c66336dcd5f7e842a..5c65a5b073e767040387bf76ec3c336898cc4b74 100755

--- a/build/android/gyp/apk_install.py

+++ b/build/android/gyp/apk_install.py

@@ -56,6 +56,11 @@ def RecordInstallMetadata(apk_package, metadata_path):

def main(argv):

+ if not build_utils.IsDeviceReady():

+ build_utils.PrintBigWarning(

+ 'No device attached. Skipping APK install.')

+ return

parser = optparse.OptionParser()

parser.add_option('--android-sdk-tools',

help='Path to Android SDK tools.')