Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types (Closed)

Created:
5 years, 2 months ago by Cutch
Modified:
5 years, 2 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org, devoncarew, danrubel, nweiz
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure that service protocol specification and implementation use the correct numeric types Fixes #24245 R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/fd6135927ec5a0efbecf309ec659254b6642552e

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -16 lines) Patch
M runtime/observatory/lib/src/service/object.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/get_vm_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M runtime/vm/service.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 2 months ago (2015-10-01 17:41:16 UTC) #2
turnidge
lgtm w/ 1 comment. https://codereview.chromium.org/1387433002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1387433002/diff/1/runtime/vm/service/service.md#newcode2122 runtime/vm/service/service.md:2122: 1.2 | Describe protocol version ...
5 years, 2 months ago (2015-10-01 17:52:58 UTC) #3
Cutch
https://codereview.chromium.org/1387433002/diff/1/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1387433002/diff/1/runtime/vm/service/service.md#newcode2122 runtime/vm/service/service.md:2122: 1.2 | Describe protocol version 3.0. Added UnresolvedSourceLocation. Added ...
5 years, 2 months ago (2015-10-01 17:54:19 UTC) #4
Cutch
5 years, 2 months ago (2015-10-01 18:05:18 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fd6135927ec5a0efbecf309ec659254b6642552e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698