runtime/observatory/tests/service/get_vm_rpc_test.dart - Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_vm_rpc_test.dart

Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/tests/service/get_vm_rpc_test.dart

diff --git a/runtime/observatory/tests/service/get_vm_rpc_test.dart b/runtime/observatory/tests/service/get_vm_rpc_test.dart

index 6aa8e33a7cfb15f4bbdc28a8516634bb8d81fcf8..d9884bdfc797efac26405c33c4a4b232a4bbbaf9 100644

--- a/runtime/observatory/tests/service/get_vm_rpc_test.dart

+++ b/runtime/observatory/tests/service/get_vm_rpc_test.dart

@@ -16,7 +16,7 @@ var tests = [

expect(result['targetCPU'], new isInstanceOf<String>());

expect(result['hostCPU'], new isInstanceOf<String>());

expect(result['version'], new isInstanceOf<String>());

- expect(result['pid'], new isInstanceOf<String>());

+ expect(result['pid'], new isInstanceOf<int>());

expect(result['startTime'], isPositive);

expect(result['isolates'].length, isPositive);

expect(result['isolates'][0]['type'], equals('@Isolate'));

« no previous file with comments | « runtime/observatory/lib/src/service/object.dart ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »