runtime/vm/service.cc - Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service.cc

Issue 1387433002: Ensure that service protocol specification and implementation use the correct numeric types (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/service.cc

diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc

index ba562356b0fefaa7a6b586ed9791ac742d21a465..47751e215fb0d98a505f62c3b77079c8065470fc 100644

--- a/runtime/vm/service.cc

+++ b/runtime/vm/service.cc

@@ -2952,10 +2952,7 @@ static bool GetVM(Isolate* isolate, JSONStream* js) {

jsobj.AddProperty("targetCPU", CPU::Id());

jsobj.AddProperty("hostCPU", HostCPUFeatures::hardware());

jsobj.AddProperty("version", Version::String());

- // Send pid as a string because it allows us to avoid any issues with

- // pids > 53-bits (when consumed by JavaScript).

- // TODO(johnmccutchan): Codify how integers are sent across the service.

- jsobj.AddPropertyF("pid", "%" Pd "", OS::ProcessId());

+ jsobj.AddProperty("pid", OS::ProcessId());

jsobj.AddProperty("_assertsEnabled", isolate->flags().asserts());

jsobj.AddProperty("_typeChecksEnabled", isolate->flags().type_checks());

int64_t start_time_millis = (Dart::vm_isolate()->start_time() /

« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »