Issue 13874004: Also treat new background tabs as pop-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13874004: Also treat new background tabs as pop-ups. (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Also treat new background tabs as pop-ups. Otherwise, a web page can create and close a new background tab to turn a previously opened pop-up into a pop-under. BUG=229402 TEST=see the example attached to the bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193493

Patch Set 1 #

Patch Set 2 : test #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
M	chrome/browser/popup_blocker_browsertest.cc	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser_tabstrip.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
A	chrome/test/data/popup_blocker/popup-fake-click-on-anchor.html	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/13874004/6001

7 years, 8 months ago (2013-04-10 19:09:25 UTC) #5

Message was sent while issue was closed.

Change committed as 193493

Expand Messages | Collapse Messages