chrome/browser/ui/browser_tabstrip.cc - Issue 13874004: Also treat new background tabs as pop-ups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tabstrip.cc

Issue 13874004: Also treat new background tabs as pop-ups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_tabstrip.cc

diff --git a/chrome/browser/ui/browser_tabstrip.cc b/chrome/browser/ui/browser_tabstrip.cc

index 2d3e83927735f5ecea73ad86f54036fa482e9af9..aa308e062e0afeaf249650315e61f0549d14608b 100644

--- a/chrome/browser/ui/browser_tabstrip.cc

+++ b/chrome/browser/ui/browser_tabstrip.cc

@@ -70,8 +70,8 @@ void AddWebContents(Browser* browser,

}

// Handle blocking of popups.

- if ((disposition == NEW_POPUP || disposition == NEW_FOREGROUND_TAB) &&

- !user_gesture &&

+ if ((disposition == NEW_POPUP || disposition == NEW_FOREGROUND_TAB ||

+ disposition == NEW_BACKGROUND_TAB) && !user_gesture &&

!CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDisablePopupBlocking)) {

// Unrequested popups from normal pages are constrained unless they're in