Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: chrome/browser/popup_blocker_browsertest.cc

Issue 13874004: Also treat new background tabs as pop-ups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_tabstrip.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/popup_blocker_browsertest.cc
diff --git a/chrome/browser/popup_blocker_browsertest.cc b/chrome/browser/popup_blocker_browsertest.cc
index aacbbefde76183bb7a0f4d250da0c950042f1ecf..48c5bfde37542a04a4662d01cad84b51474962a2 100644
--- a/chrome/browser/popup_blocker_browsertest.cc
+++ b/chrome/browser/popup_blocker_browsertest.cc
@@ -77,8 +77,7 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest {
ASSERT_TRUE(blocked_contents.empty());
}
- void BasicTest(Browser* browser) {
- GURL url(GetTestURL());
+ void BasicTest(Browser* browser, const GURL& url) {
ui_test_utils::NavigateToURL(browser, url);
// If the popup blocker blocked the blank post, there should be only one
@@ -107,12 +106,19 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest {
};
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, PopupBlockedPostBlank) {
- BasicTest(browser());
+ BasicTest(browser(), GetTestURL());
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest,
PopupBlockedPostBlankIncognito) {
- BasicTest(CreateIncognitoBrowser());
+ BasicTest(CreateIncognitoBrowser(), GetTestURL());
+}
+
+IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, PopupBlockedFakeClickOnAnchor) {
+ GURL url(ui_test_utils::GetTestUrl(
+ base::FilePath(kTestDir),
+ base::FilePath(FILE_PATH_LITERAL("popup-fake-click-on-anchor.html"))));
+ BasicTest(browser(), url);
}
IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MultiplePopups) {
« no previous file with comments | « no previous file | chrome/browser/ui/browser_tabstrip.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698