Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138703003: Add blink_heap_unittests to android recipe. (Closed)

Created:
6 years, 11 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
caseq, navabi1, Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +2 lines, -0 lines 3 comments Download

Messages

Total messages: 15 (0 generated)
Dirk Pranke
6 years, 11 months ago (2014-01-14 22:02:04 UTC) #1
Dirk Pranke
https://codereview.chromium.org/138703003/diff/1/build/android/pylib/gtest/setup.py File build/android/pylib/gtest/setup.py (right): https://codereview.chromium.org/138703003/diff/1/build/android/pylib/gtest/setup.py#newcode32 build/android/pylib/gtest/setup.py:32: 'third_party/WebKit/Source/heap/blink_heap_unittests.isolate', Is this really necessary / used ? Why ...
6 years, 11 months ago (2014-01-14 22:02:49 UTC) #2
Yaron
Unfortunately this isn't enough on android. For a number of reasons, we don't just run ...
6 years, 11 months ago (2014-01-14 23:40:36 UTC) #3
Dirk Pranke
Okay, I've posted a CL for the blink_heap_unittests_apk to https://codereview.chromium.org/148453004 (it includes an isolate file). ...
6 years, 10 months ago (2014-01-27 21:16:59 UTC) #4
Yaron
lgtm
6 years, 10 months ago (2014-01-27 22:29:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/138703003/1
6 years, 10 months ago (2014-01-28 21:36:20 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217443
6 years, 10 months ago (2014-01-28 22:34:00 UTC) #7
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-01 16:59:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/138703003/1
6 years, 10 months ago (2014-02-01 16:59:44 UTC) #9
commit-bot: I haz the power
Change committed as 248379
6 years, 10 months ago (2014-02-02 05:52:11 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 05:52:13 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-02 05:52:20 UTC) #12
caseq
Note this keep failing on WebKit Android (Nexus4): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29?numbuilds=50
6 years, 10 months ago (2014-02-03 09:46:02 UTC) #13
navabi1
https://codereview.chromium.org/138703003/diff/1/build/android/pylib/gtest/setup.py File build/android/pylib/gtest/setup.py (right): https://codereview.chromium.org/138703003/diff/1/build/android/pylib/gtest/setup.py#newcode32 build/android/pylib/gtest/setup.py:32: 'third_party/WebKit/Source/heap/blink_heap_unittests.isolate', On 2014/01/14 23:40:36, Yaron wrote: > On 2014/01/14 ...
6 years, 10 months ago (2014-02-03 17:21:40 UTC) #14
Dirk Pranke
6 years, 10 months ago (2014-02-03 17:56:34 UTC) #15
Message was sent while issue was closed. 
On 2014/02/03 17:21:40, navabi1 wrote:
> The isolate filename here is wrong. It is "BlinkHeapUnitTests.isolate". I saw
> this after caseq pointed out failures on the WebKit bot, and I looked at the
> error.

Good catch. Will fix and try again.

Powered by Google App Engine
This is Rietveld 408576698