Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 148453004: Add a blink_heap_unittests_apk so we can run the tests on Android. (Closed)

Created:
6 years, 11 months ago by Dirk Pranke
Modified:
6 years, 11 months ago
CC:
blink-reviews, haraken, jamesr, dglazkov+blink, Mads Ager (chromium), abarth-chromium
Visibility:
Public.

Description

Add a blink_heap_unittests_apk so we can run the tests on Android. R=yfriedman@chromium.org, maruel@chromium.org, abarth@chromium.org BUG=334018 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165897

Patch Set 1 #

Patch Set 2 : add BlinkHeapUnitTests.isolate #

Total comments: 2

Patch Set 3 : fix spaces in condition per review comment #

Total comments: 2

Patch Set 4 : remove obsolete input_shlib_path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
A + Source/heap/BlinkHeapUnitTests.isolate View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/heap/blink_heap_tests.gyp View 1 2 3 2 chunks +25 lines, -1 line 0 comments Download
M public/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dirk Pranke
yfriedman - does this change look correct? maruel - do we actually need isolates for ...
6 years, 11 months ago (2014-01-27 21:18:46 UTC) #1
M-A Ruel
> maruel - do we actually need isolates for android unit tests? Yes, it's how ...
6 years, 11 months ago (2014-01-27 21:27:53 UTC) #2
Dirk Pranke
https://codereview.chromium.org/148453004/diff/10001/Source/heap/blink_heap_tests.gyp File Source/heap/blink_heap_tests.gyp (right): https://codereview.chromium.org/148453004/diff/10001/Source/heap/blink_heap_tests.gyp#newcode83 Source/heap/blink_heap_tests.gyp:83: ['OS=="android" and android_webview_build==0 and gtest_target_type == "shared_library"', { On ...
6 years, 11 months ago (2014-01-27 22:09:39 UTC) #3
Yaron
lgtm https://codereview.chromium.org/148453004/diff/30001/Source/heap/blink_heap_tests.gyp File Source/heap/blink_heap_tests.gyp (right): https://codereview.chromium.org/148453004/diff/30001/Source/heap/blink_heap_tests.gyp#newcode94 Source/heap/blink_heap_tests.gyp:94: 'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)webkit_unit_tests<(SHARED_LIB_SUFFIX)', This is the wrong value but ...
6 years, 11 months ago (2014-01-27 22:25:33 UTC) #4
Dirk Pranke
https://codereview.chromium.org/148453004/diff/30001/Source/heap/blink_heap_tests.gyp File Source/heap/blink_heap_tests.gyp (right): https://codereview.chromium.org/148453004/diff/30001/Source/heap/blink_heap_tests.gyp#newcode94 Source/heap/blink_heap_tests.gyp:94: 'input_shlib_path': '<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)webkit_unit_tests<(SHARED_LIB_SUFFIX)', On 2014/01/27 22:25:34, Yaron wrote: > This ...
6 years, 11 months ago (2014-01-27 22:46:19 UTC) #5
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-27 23:13:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/148453004/50001
6 years, 11 months ago (2014-01-28 00:01:25 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-28 01:21:18 UTC) #8
Message was sent while issue was closed.
Change committed as 165897

Powered by Google App Engine
This is Rietveld 408576698