Issue 1386823002: Only call DefineJSObjects() once for the global V8 isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1386823002: Only call DefineJSObjects() once for the global V8 isolate. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com, jochen (gone - plz use gerrit), raymes

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Lei Zhang

Committed patchset #1 (id:1) manually as 7dfe5929282cb6d78d7b5e32e1d72e9db99d3066 (presubmit successful).

5 years, 2 months ago (2015-10-05 03:40:19 UTC) #4

Message was sent while issue was closed.

lgtm