fpdfsdk/src/javascript/JS_Runtime.cpp - Issue 1386823002: Only call DefineJSObjects() once for the global V8 isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Runtime.cpp

Issue 1386823002: Only call DefineJSObjects() once for the global V8 isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/javascript/JS_Runtime.cpp

diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp

index 4c502a7b757ea453a3df884107053c4f4be50e7d..707551adbe31178d7a5240971fb468d5982453e9 100644

--- a/fpdfsdk/src/javascript/JS_Runtime.cpp

+++ b/fpdfsdk/src/javascript/JS_Runtime.cpp

@@ -45,7 +45,8 @@ CJS_Runtime::CJS_Runtime(CPDFDoc_Environment* pApp)

FXJS_Initialize(embedderDataSlot, pExternalIsolate);

}

m_isolateManaged = FXJS_GetIsolate(&m_isolate);

- DefineJSObjects();

+ if (m_isolateManaged || FXJS_GlobalIsolateRefCount() == 0)

+ DefineJSObjects();

CJS_Context* pContext = (CJS_Context*)NewContext();

FXJS_InitializeRuntime(GetIsolate(), this, pContext, m_context);

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/src/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »