Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1386823002: Only call DefineJSObjects() once for the global V8 isolate. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 // PDFium wrapper around V8 APIs. PDFium code should include this file rather 7 // PDFium wrapper around V8 APIs. PDFium code should include this file rather
8 // than including V8 headers directly. 8 // than including V8 headers directly.
9 9
10 #ifndef FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_ 10 #ifndef FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 63
64 // Call before making FXJS_PrepareIsolate call. 64 // Call before making FXJS_PrepareIsolate call.
65 void FXJS_Initialize(unsigned int embedderDataSlot, v8::Isolate* pIsolate); 65 void FXJS_Initialize(unsigned int embedderDataSlot, v8::Isolate* pIsolate);
66 void FXJS_Release(); 66 void FXJS_Release();
67 67
68 // Gets the global isolate set by FXJS_Initialize(), or makes a new one each 68 // Gets the global isolate set by FXJS_Initialize(), or makes a new one each
69 // time if there is no such isolate. Returns true if a new isolate had to be 69 // time if there is no such isolate. Returns true if a new isolate had to be
70 // created. 70 // created.
71 bool FXJS_GetIsolate(v8::Isolate** pResultIsolate); 71 bool FXJS_GetIsolate(v8::Isolate** pResultIsolate);
72 72
73 // Get the global isolate's ref count.
74 size_t FXJS_GlobalIsolateRefCount();
75
73 // Call before making FXJS_Define* calls. Resources allocated here are cleared 76 // Call before making FXJS_Define* calls. Resources allocated here are cleared
74 // as part of FXJS_ReleaseRuntime(). 77 // as part of FXJS_ReleaseRuntime().
75 void FXJS_PrepareIsolate(v8::Isolate* pIsolate); 78 void FXJS_PrepareIsolate(v8::Isolate* pIsolate);
76 79
77 // Call before making JS_Define* calls. Resources allocated here are cleared 80 // Call before making JS_Define* calls. Resources allocated here are cleared
78 // as part of JS_ReleaseRuntime(). 81 // as part of JS_ReleaseRuntime().
79 void JS_PrepareIsolate(v8::Isolate* pIsolate); 82 void JS_PrepareIsolate(v8::Isolate* pIsolate);
80 83
81 // Always returns a valid, newly-created objDefnID. 84 // Always returns a valid, newly-created objDefnID.
82 int FXJS_DefineObj(v8::Isolate* pIsolate, 85 int FXJS_DefineObj(v8::Isolate* pIsolate,
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 double FXJS_ToNumber(v8::Isolate* pIsolate, v8::Local<v8::Value> pValue); 213 double FXJS_ToNumber(v8::Isolate* pIsolate, v8::Local<v8::Value> pValue);
211 v8::Local<v8::Object> FXJS_ToObject(v8::Isolate* pIsolate, 214 v8::Local<v8::Object> FXJS_ToObject(v8::Isolate* pIsolate,
212 v8::Local<v8::Value> pValue); 215 v8::Local<v8::Value> pValue);
213 CFX_WideString FXJS_ToString(v8::Isolate* pIsolate, 216 CFX_WideString FXJS_ToString(v8::Isolate* pIsolate,
214 v8::Local<v8::Value> pValue); 217 v8::Local<v8::Value> pValue);
215 v8::Local<v8::Array> FXJS_ToArray(v8::Isolate* pIsolate, 218 v8::Local<v8::Array> FXJS_ToArray(v8::Isolate* pIsolate,
216 v8::Local<v8::Value> pValue); 219 v8::Local<v8::Value> pValue);
217 void FXJS_ValueCopy(v8::Local<v8::Value>& pTo, v8::Local<v8::Value> pFrom); 220 void FXJS_ValueCopy(v8::Local<v8::Value>& pTo, v8::Local<v8::Value> pFrom);
218 221
219 #endif // FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_ 222 #endif // FPDFSDK_INCLUDE_JSAPI_FXJS_V8_H_
OLDNEW
« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698