Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Try to fix ASSERTs Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index dd9a465ebe7663256e45ac43da84acb16e33359c..47b6fa33d8f2a6e3dc9755f558399b7d49879669 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -443,16 +443,17 @@ z-index interpolable, type_name=int, custom_all
// TODO(timloh): This seems wrong, most of these shouldn't reach the StyleBuilder
all builder_skip
-font-display builder_skip, runtime_flag=CSSFontDisplay
-max-zoom builder_skip
-min-zoom builder_skip
-orientation builder_skip
page builder_skip
-src builder_skip
-unicode-range builder_skip
-user-zoom builder_skip
-webkit-font-size-delta builder_skip
-webkit-text-decorations-in-effect inherited, builder_skip
+// descriptors go here
Timothy Loh 2016/05/31 07:35:10 blank line before comment
+font-display descriptor_only, runtime_flag=CSSFontDisplay
+max-zoom descriptor_only
+min-zoom descriptor_only
+orientation descriptor_only
+src descriptor_only
+unicode-range descriptor_only
+user-zoom descriptor_only
// Shorthands
« third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698