third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl - Issue 1386733003: Do not accept CSS-wide keywords for descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix ASSERTs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_style_builder.py ('k') | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | third_party/WebKit/Source/core/css/CSSProperties.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

index 821a88532b71f0101fce5496aef1b5d3dd846d68..6cd825e859d5e99a8b980eff4948edb838ffa0e0 100644

--- a/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

@@ -62,4 +62,9 @@ void CSSPropertyMetadata::filterEnabledCSSPropertiesIntoVector(const CSSProperty

}

+bool CSSPropertyMetadata::isDescriptor(CSSPropertyID property)

Timothy Loh 2016/05/31 03:24:05 let's rename this to isDecriptorOnly (similar to t

+ return property >= {{descriptors[0].property_id}} && property <= {{descriptors[-1].property_id}};

} // namespace blink