third_party/WebKit/Source/core/css/CSSProperty.cpp - Issue 1386733003: Do not accept CSS-wide keywords for descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSProperty.cpp

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Try to fix ASSERTs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSProperty.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSProperty.cpp b/third_party/WebKit/Source/core/css/CSSProperty.cpp

index 94900d4c5c17b50f6d166f865dce58ac94d58733..4959d20bbb3ee37db3fc3c8bf8cb784ed59f0fd7 100644

--- a/third_party/WebKit/Source/core/css/CSSProperty.cpp

+++ b/third_party/WebKit/Source/core/css/CSSProperty.cpp

@@ -230,6 +230,9 @@ bool CSSProperty::isAffectedByAllProperty(CSSPropertyID propertyID)

if (propertyID == CSSPropertyVariable)

return false;

+ if (CSSPropertyMetadata::isDescriptor(propertyID))

+ return false;

// all shorthand spec says:

// The all property is a shorthand that resets all CSS properties except

// direction and unicode-bidi. It only accepts the CSS-wide keywords.