Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1386453003: Oilpan: Force a page navigation GC before starting a V8 GC (Closed)

Created:
5 years, 2 months ago by haraken
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-bindings_chromium.org, blink-reviews, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Force a page navigation GC before starting a V8 GC This fixes a performance regression of iframe-append-remove.html. The fact that the PageNavigation GC is scheduled means that there is a dead frame. In common cases, a sequence of Oilpan's GC => V8 GC => Oilpan's GC is needed to collect the dead frame. So we force the PageNavigation GC before running the V8 GC. I don't think this CL affects performance of other benchmarks, since it would be rare to hit a V8 GC between when a PageNavigation GC gets scheduled and when the event loop finishes (i.e., when the PageNavigation GC runs). BUG=474470 Committed: https://crrev.com/2a1b03ebb89a061babaa85bc88dbecab8081db34 Cr-Commit-Position: refs/heads/master@{#352576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
haraken
PTAL
5 years, 2 months ago (2015-10-06 08:06:10 UTC) #2
haraken
On 2015/10/06 08:06:10, haraken wrote: > PTAL I think this would be a better fix ...
5 years, 2 months ago (2015-10-06 08:07:01 UTC) #3
sof
lgtm
5 years, 2 months ago (2015-10-06 08:35:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386453003/1
5 years, 2 months ago (2015-10-06 08:38:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 09:57:05 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 09:57:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a1b03ebb89a061babaa85bc88dbecab8081db34
Cr-Commit-Position: refs/heads/master@{#352576}

Powered by Google App Engine
This is Rietveld 408576698