Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1386453003: Oilpan: Force a page navigation GC before starting a V8 GC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index 197fcecaa010a6911f2b7972977a1320406a464d..4a91393bccf7902be634016cc1041ff86f795647 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -690,6 +690,29 @@ void ThreadState::scheduleV8FollowupGCIfNeeded(V8GCType gcType)
}
}
+void ThreadState::willStartV8GC()
+{
+ // Finish Oilpan's complete sweeping before running a V8 GC.
+ // This will let the GC collect more V8 objects.
+ //
+ // TODO(haraken): It's a bit too late for a major GC to schedule
+ // completeSweep() here, because gcPrologue for a major GC is called
+ // not at the point where the major GC started but at the point where
+ // the major GC requests object grouping.
+ completeSweep();
+
+ // The fact that the PageNavigation GC is scheduled means that there is
+ // a dead frame. In common cases, a sequence of Oilpan's GC => V8 GC =>
+ // Oilpan's GC is needed to collect the dead frame. So we force the
+ // PageNavigation GC before running the V8 GC.
+ if (gcState() == PageNavigationGCScheduled) {
+#if PRINT_HEAP_STATS
+ dataLogF("Scheduled PageNavigationGC\n");
+#endif
+ Heap::collectGarbage(HeapPointersOnStack, GCWithSweep, Heap::PageNavigationGC);
+ }
+}
+
void ThreadState::schedulePageNavigationGCIfNeeded(float estimatedRemovalRatio)
{
ASSERT(checkThread());
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698