Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp

Issue 1386453003: Oilpan: Force a page navigation GC before starting a V8 GC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
index 0e4d9ff081df81d820eb008ab0a5ab768cd119b6..d37514736d20a7124f5cfcb7b788c0bde8bd971d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
@@ -376,15 +376,8 @@ void gcPrologueForMajorGC(v8::Isolate* isolate, bool constructRetainedObjectInfo
void V8GCController::gcPrologue(v8::GCType type, v8::GCCallbackFlags flags)
{
- // Finish Oilpan's complete sweeping before running a V8 GC.
- // This will let the GC collect more V8 objects.
- //
- // TODO(haraken): It's a bit too late for a major GC to schedule
- // completeSweep() here, because gcPrologue for a major GC is called
- // not at the point where the major GC started but at the point where
- // the major GC requests object grouping.
if (ThreadState::current())
- ThreadState::current()->completeSweep();
+ ThreadState::current()->willStartV8GC();
if (isMainThread()) {
ScriptForbiddenScope::enter();
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698