Issue 138613002: Make generated Callback bindings classes FINAL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138613002: Make generated Callback bindings classes FINAL (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make generated Callback bindings classes FINAL Make generated Callback bindings classes FINAL and add OVERRIDE to their virtual methods. R=haraken BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165111

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/templates/callback_interface.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestCallbackInterface.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/138613002/1

6 years, 11 months ago (2014-01-14 23:35:31 UTC) #3

Message was sent while issue was closed.

Change committed as 165111

Expand Messages | Collapse Messages