Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: Source/bindings/templates/callback_interface.h

Issue 138613002: Make generated Callback bindings classes FINAL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/callback_interface.h
diff --git a/Source/bindings/templates/callback_interface.h b/Source/bindings/templates/callback_interface.h
index acd58673bea4b5b2d1d81b7b924e6983129afd9e..6b32aaacd75067a89513d479836fc2ff55816287 100644
--- a/Source/bindings/templates/callback_interface.h
+++ b/Source/bindings/templates/callback_interface.h
@@ -44,7 +44,7 @@ namespace WebCore {
class ExecutionContext;
-class {{v8_class}} : public {{cpp_class}}, public ActiveDOMCallback {
+class {{v8_class}} FINAL : public {{cpp_class}}, public ActiveDOMCallback {
public:
static PassOwnPtr<{{v8_class}}> create(v8::Handle<v8::Function> callback, ExecutionContext* context)
{
@@ -55,7 +55,7 @@ public:
virtual ~{{v8_class}}();
{% for method in methods %}
- virtual {{method.return_cpp_type}} {{method.name}}({{method.argument_declarations | join(', ')}});
+ virtual {{method.return_cpp_type}} {{method.name}}({{method.argument_declarations | join(', ')}}) OVERRIDE;
{% endfor %}
private:
{{v8_class}}(v8::Handle<v8::Function>, ExecutionContext*);
« no previous file with comments | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/results/V8TestCallbackInterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698