Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 138613002: Make generated Callback bindings classes FINAL (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index fe3aad63946f832cf861867ba562b4e5be7bfba1..949a2262119f32bb250e87c8a1dc740f64289c6e 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -4877,7 +4877,7 @@ sub GenerateCallbackHeader
$header{includes}->add("#include \"$include\"\n");
}
$header{nameSpaceWebCore}->addHeader("\nclass ExecutionContext;\n");
- $header{class}->addHeader("class $v8ClassName : public $implClassName, public ActiveDOMCallback {");
+ $header{class}->addHeader("class $v8ClassName FINAL : public $implClassName, public ActiveDOMCallback {");
$header{class}->addFooter("};\n");
$header{classPublic}->add(<<END);
@@ -4906,7 +4906,7 @@ END
push(@args, GetNativeTypeForCallbacks($param->type) . " " . $param->name);
}
$code .= join(", ", @args);
- $code .= ");\n";
+ $code .= ") OVERRIDE;\n";
$header{classPublic}->add($code);
}
}
« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698