cc: Remove SetLayerTreeHostClientReady()

cc: Remove SetLayerTreeHostClientReady()

There are no call sites that need this anymore, the behavior
can be achieved in other ways now that OutputSurface creation
has been async for a while.

Also make the default LTH state invisible to match the scheduler
init state. This also avoids races where we'd otherwise schedule
actions when starting the proxy (i.e. LTH creation time)
which were previously delayed until setLTHClientReady().

BUG=538714, 539991
TBR=dtrainor@chromium.org

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/71c62dd5e2913b6c4b7f02338aa84120d73da5a5
Cr-Commit-Position: refs/heads/master@{#352742}

[no sievers, 2015-10-05 19:51:04]

sievers@chromium.org changed reviewers:
+ reveman@chromium.org

[no sievers, 2015-10-05 19:51:11]

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:6574: // dirties tile priorities.
@reveman: thoughts on this?

[no sievers, 2015-10-05 19:57:43]

On 2015/10/05 19:51:11, sievers wrote:
>
https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
> File cc/trees/layer_tree_host_impl_unittest.cc (right):
> 
>
https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
> cc/trees/layer_tree_host_impl_unittest.cc:6574: // dirties tile priorities.
> @reveman: thoughts on this?

I'm not entirely sure changing the default state is the best idea.
Maybe you have some thoughts on that.

I do find the way how visibility syncs from LTH/LTHImpl to the scheduler a bit
odd:

For the SingleThreadProxy it happens from SetLTHClientReady. For the threaded
one it happens during init.
So maybe there is an argument for defining the initial state better.

[no sievers, 2015-10-05 19:58:22]

sievers@chromium.org changed reviewers:
+ danakj@chromium.org

[piman, 2015-10-05 22:28:58]

piman@chromium.org changed reviewers:
+ piman@chromium.org

[piman, 2015-10-05 22:28:59]

drive-by LGTM

[reveman, 2015-10-06 00:46:06]

lgtm

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:6574: // dirties tile priorities.
On 2015/10/05 at 19:51:10, sievers wrote:
> @reveman: thoughts on this?

we can fix this in a follow up if needed. maybe just add another
SetVisible(false) at the top here?

[no sievers, 2015-10-06 19:39:47]

Thanks guys!

In ps3 I've made more cc tests set the LTH/LTHI to visible, even if they were
previously passing. Just so that they don't silently end up verifying some
assumption that is only true because we are not even visible. I've done this for
all the ones that initialize a renderer or do a synchronous Composite.

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
File cc/trees/layer_tree_host_impl_unittest.cc (right):

https://codereview.chromium.org/1385043002/diff/1/cc/trees/layer_tree_host_im...
cc/trees/layer_tree_host_impl_unittest.cc:6574: // dirties tile priorities.
On 2015/10/06 00:46:05, reveman wrote:
> On 2015/10/05 at 19:51:10, sievers wrote:
> > @reveman: thoughts on this?
> 
> we can fix this in a follow up if needed. maybe just add another
> SetVisible(false) at the top here?

Done.

[no sievers, 2015-10-06 22:45:01]

Dana was suggesting to split the patch into two parts: remove
setLTHClientReady(), and change LTH default visibility.
But I just realized again that this creates races since in the absence of the
'canStart' signal the scheduler will go and schedule tasks already at LTH
creation time, if visible (I updated the cl description). So I'll attempt to
land this as-is somehow.

Also filed crbug.com/540026 with TODO, since I'm not sure for that call site if
it was intentional that we never called setLTHClientReady() there.

[no sievers, 2015-10-06 23:29:16]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2015-10-06 23:29:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1385043002/#ps80001
(title: "fix webkit_unit_tests")

[commit-bot: I haz the power, 2015-10-06 23:31:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385043002/80001

[no sievers, 2015-10-06 23:49:36]

The CQ bit was unchecked by sievers@chromium.org

[no sievers, 2015-10-06 23:49:43]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2015-10-06 23:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 23:50:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[no sievers, 2015-10-06 23:56:19]

sievers@chromium.org changed reviewers:
+ sky@chromium.org

[no sievers, 2015-10-07 00:06:56]

Patchset #6 (id:100001) has been deleted

[no sievers, 2015-10-07 00:09:54]

+sky for components/html_viewer/web_layer_tree_view_impl.cc

[no sievers, 2015-10-07 00:32:55]

The CQ bit was checked by sievers@chromium.org

[no sievers, 2015-10-07 00:32:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1385043002/#ps120001
(title: "sky's offline comment")

[commit-bot: I haz the power, 2015-10-07 00:35:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385043002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385043002/120001

[sky, 2015-10-07 01:37:36]

sky@chromium.org changed reviewers:
+ fsamuel@chromium.org

[sky, 2015-10-07 01:37:36]

LGTM
+fsamuel

[commit-bot: I haz the power, 2015-10-07 01:44:58]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-10-07 01:45:48]

Patchset 6 (id:??) landed as
https://crrev.com/71c62dd5e2913b6c4b7f02338aa84120d73da5a5
Cr-Commit-Position: refs/heads/master@{#352742}