Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: cc/trees/layer_tree_host_unittest_context.cc

Issue 1385043002: cc: Remove SetLayerTreeHostClientReady() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startcomp
Patch Set: sky's offline comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_context.cc
diff --git a/cc/trees/layer_tree_host_unittest_context.cc b/cc/trees/layer_tree_host_unittest_context.cc
index 34a70b9ab4503d897f0b09d94633d512ed3a8920..0754ef1d11fcca7a54a3bd6602df0554b6302664 100644
--- a/cc/trees/layer_tree_host_unittest_context.cc
+++ b/cc/trees/layer_tree_host_unittest_context.cc
@@ -354,14 +354,15 @@ class LayerTreeHostContextTestLostContextSucceeds
SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostContextTestLostContextSucceeds);
-class LayerTreeHostClientNotReadyDoesNotCreateOutputSurface
+class LayerTreeHostClientNotVisibleDoesNotCreateOutputSurface
: public LayerTreeHostContextTest {
public:
- LayerTreeHostClientNotReadyDoesNotCreateOutputSurface()
+ LayerTreeHostClientNotVisibleDoesNotCreateOutputSurface()
: LayerTreeHostContextTest() {}
void WillBeginTest() override {
- // Override and do not signal SetLayerTreeHostClientReady.
+ // Override to not become visible.
+ DCHECK(!layer_tree_host()->visible());
}
void BeginTest() override {
@@ -380,7 +381,7 @@ class LayerTreeHostClientNotReadyDoesNotCreateOutputSurface
};
SINGLE_AND_MULTI_THREAD_TEST_F(
- LayerTreeHostClientNotReadyDoesNotCreateOutputSurface);
+ LayerTreeHostClientNotVisibleDoesNotCreateOutputSurface);
// This tests the OutputSurface release logic in the following sequence.
// SetUp LTH and create and init OutputSurface
@@ -1525,8 +1526,8 @@ class UIResourceLostEviction : public UIResourceLostTestSimple {
}
void DidSetVisibleOnImplTree(LayerTreeHostImpl* impl, bool visible) override {
- TestWebGraphicsContext3D* context = TestContext();
if (!visible) {
+ TestWebGraphicsContext3D* context = TestContext();
// All resources should have been evicted.
ASSERT_EQ(0u, context->NumTextures());
EXPECT_EQ(0u, impl->ResourceIdForUIResource(ui_resource_->id()));
« no previous file with comments | « cc/trees/layer_tree_host_unittest.cc ('k') | cc/trees/layer_tree_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698