Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1384823002: Add "--test-type=gpu" to suppress API Keys InfoBar (Closed)

Created:
5 years, 2 months ago by ericrk
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Currently, when running tests on the GPU bots, we occasionally have flakiness due to the presence (and subsequent hiding) of the "Google API keys are missing" bar that appears at the top of the window when a test starts (see crbug.com/533181). This change adds the "test-type" flag, which suppresses this InfoBar, among other things. Initial testing indicates that the other side-effects to not interfere with GPU tests. BUG=537776 Committed: https://crrev.com/cf5399db86adcbd97f5a2c7044cedc6747aaac49 Cr-Commit-Position: refs/heads/master@{#352443}

Patch Set 1 #

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/screenshot_sync.py View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance.py View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ken Russell (switch to Gerrit)
lgtm Thanks for investigating this. Could you add a comment in the various source files ...
5 years, 2 months ago (2015-10-05 20:29:40 UTC) #2
ericrk
On 2015/10/05 at 20:29:40, kbr wrote: > lgtm > > Thanks for investigating this. > ...
5 years, 2 months ago (2015-10-05 20:45:47 UTC) #3
Ken Russell (switch to Gerrit)
lgtm again. Thanks for taking care of this.
5 years, 2 months ago (2015-10-05 20:50:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384823002/20001
5 years, 2 months ago (2015-10-05 21:45:23 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 22:21:15 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:22:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf5399db86adcbd97f5a2c7044cedc6747aaac49
Cr-Commit-Position: refs/heads/master@{#352443}

Powered by Google App Engine
This is Rietveld 408576698