Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: content/test/gpu/gpu_tests/webgl_conformance.py

Issue 1384823002: Add "--test-type=gpu" to suppress API Keys InfoBar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/screenshot_sync.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/webgl_conformance.py
diff --git a/content/test/gpu/gpu_tests/webgl_conformance.py b/content/test/gpu/gpu_tests/webgl_conformance.py
index cb1163fe3b186de3763fc583e05d130e3a15e544..d576894a8b2397d4275d7ae3ba17806b4b63d7c9 100644
--- a/content/test/gpu/gpu_tests/webgl_conformance.py
+++ b/content/test/gpu/gpu_tests/webgl_conformance.py
@@ -82,10 +82,13 @@ class WebglConformanceValidator(gpu_test_base.ValidatorBase):
raise page_test.Failure(_WebGLTestMessages(tab))
def CustomizeBrowserOptions(self, options):
+ # --test-type=gpu is used only to suppress the "Google API Keys are missing"
+ # infobar, which causes flakiness in tests.
options.AppendExtraBrowserArgs([
'--disable-gesture-requirement-for-media-playback',
'--disable-domain-blocking-for-3d-apis',
- '--disable-gpu-process-crash-limit'
+ '--disable-gpu-process-crash-limit',
+ '--test-type=gpu'
])
browser = browser_finder.FindBrowser(options.finder_options)
if (browser.target_os.startswith('android') and
@@ -107,11 +110,14 @@ class Webgl2ConformanceValidator(WebglConformanceValidator):
super(Webgl2ConformanceValidator, self).__init__()
def CustomizeBrowserOptions(self, options):
+ # --test-type=gpu is used only to suppress the "Google API Keys are missing"
+ # infobar, which causes flakiness in tests.
options.AppendExtraBrowserArgs([
'--disable-gesture-requirement-for-media-playback',
'--disable-domain-blocking-for-3d-apis',
'--disable-gpu-process-crash-limit',
- '--enable-unsafe-es3-apis'
+ '--enable-unsafe-es3-apis',
+ '--test-type=gpu'
])
class WebglConformancePage(gpu_test_base.PageBase):
« no previous file with comments | « content/test/gpu/gpu_tests/screenshot_sync.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698