Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/test/gpu/gpu_tests/pixel.py

Issue 1384823002: Add "--test-type=gpu" to suppress API Keys InfoBar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/maps.py ('k') | content/test/gpu/gpu_tests/screenshot_sync.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/pixel.py
diff --git a/content/test/gpu/gpu_tests/pixel.py b/content/test/gpu/gpu_tests/pixel.py
index f20bc33958a53250fd02aa31aee2008915e3ba7b..52acf469241c1d96c6f398f68ea1005eec159cbc 100644
--- a/content/test/gpu/gpu_tests/pixel.py
+++ b/content/test/gpu/gpu_tests/pixel.py
@@ -51,7 +51,10 @@ def _DidTestSucceed(tab):
class PixelValidator(cloud_storage_test_base.ValidatorBase):
def CustomizeBrowserOptions(self, options):
- options.AppendExtraBrowserArgs('--enable-gpu-benchmarking')
+ # --test-type=gpu is used only to suppress the "Google API Keys are missing"
+ # infobar, which causes flakiness in tests.
+ options.AppendExtraBrowserArgs(['--enable-gpu-benchmarking',
+ '--test-type=gpu'])
def ValidateAndMeasurePage(self, page, tab, results):
if not _DidTestSucceed(tab):
« no previous file with comments | « content/test/gpu/gpu_tests/maps.py ('k') | content/test/gpu/gpu_tests/screenshot_sync.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698