GN: Fix Chrome crashing on start-up

build/config/android/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/sysroot.gni")
 
 assert(is_android)
 
@@ skipping 125 matching lines @@
     "-isystem" +
         rebase_path("$android_libcpp_root/libcxx/include", root_build_dir),
     "-isystem" + rebase_path(
             "$android_ndk_root/sources/cxx-stl/llvm-libc++abi/libcxxabi/include",
             root_build_dir),
     "-isystem" +
         rebase_path("$android_ndk_root/sources/android/support/include",
                     root_build_dir),
   ]
 
+  # The libc++ runtime library.
+  _libcpp = "c++_static"
+  if (is_component_build) {
+    _libcpp = "c++_shared"
+  }
+
   defines = [ "__GNU_SOURCE=1" ]  # Necessary for clone().
   ldflags = [ "-nostdlib" ]
   lib_dirs = [ "$android_libcpp_root/libs/$android_app_abi" ]
   libs = [

[brettw, 2015/10/02 18:13:16]

I'd prefer to have this as

if (is_com...) {  # C++ library must come first
  libs = [ ... ]
} else {
  libs = [ ... ]
}
libs += [ the other stuff ]

[agrieve, 2015/10/02 18:16:38]

Done.

+    _libcpp,  # Must come first.
     "c",
     "dl",
     "m",
   ]
 
-  # The libc++ runtime library.
-  if (is_component_build) {
-    libs += [ "c++_shared" ]
-  } else {
-    libs += [ "c++_static" ]
-  }
-
   if (is_clang) {
     # Work around incompatibilities between bionic and clang headers.
     defines += [
       "__compiler_offsetof=__builtin_offsetof",
       "nan=__builtin_nan",
     ]
   }
 
   # TODO(jdduke) Re-enable on mips after resolving linking
   # issues with libc++ (crbug.com/456380).
@@ skipping 77 matching lines @@
 
     # Avoid errors with current NDK:
     # "third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin/../lib/gcc/arm-linux-androideabi/4.6/include/arm_neon.h:3426:3: error: argument must be a constant"
     "-finstrument-functions-exclude-file-list=arm_neon.h,SaturatedArithmeticARM.h",
   ]
   defines = [ "CYGPROFILE_INSTRUMENTATION=1" ]
 }
 
 config("no_cygprofile_instrumentation") {
 }